Update nws/nwc naming convention #367
Conversation
davidegorbani
changed the title
nws/nwc naming convention
|
Great @davidegorbani, I will go trough this PR soon. CI on Windows is failing, but the issue seems to be unrelated to your PR. Moreover, before merging I would like to fix #366 and do a Release, since this PR will break compatibility with old configurations. |
|
I rebased the branch on master, I tested on my laptop the HumanStateVisualizer and it is working fine. |
Great, however there seems to be a conflict in the files and the commit history seems not to be clean. We can have a look at this together tomorrow! |
davidegorbani
force-pushed
the
update_nws_nwc_name
branch
from
a9fc4ed to
559af64
Compare
There was a problem hiding this comment.
Thanks for the PR @davidegorbani. A couple of comments:
- can you update the
CHANGELOG.mdwith the relevant modifications? - I think we can also change the name of the folders in which those files are currently stored (so removing the
wrappersandremappersfolder).
Yes, sure.
I was considering changing those names, is it fine |
There was a problem hiding this comment.
@davidegorbani can you take care of updating all the configuration files inside conf? Even if you cannot test them, you can simply fins and replace all the names. Eventually we can test together at least those that are actively used for the ergoCub robot teleoperation.
|
Yes, sure! |
|
I changed also the name of the namespaces. |
This PR closes #359; with this PR the naming convention of the Wrapper and the Remapper is updated to the
nws/nwcnow used for the servers and clients in YARP.